[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Precision "display mode" for KoRuler
From:       "Aron Stansvik" <elvstone () gmail ! com>
Date:       2008-01-18 17:55:46
Message-ID: 751a4f870801180955r30e46d64p80816cfea9eeb576 () mail ! gmail ! com
[Download RAW message or body]

2008/1/17, C. Boemann <cbr@boemann.dk>:
> from a quick glance I think it looks ok, however:
>
> - why not cache the strategies rather than create and delete them everytime
> shift is pressed or released

Hm. You mean have a KoRulerPrivate::lastStrategy which holds the last
strategy and just flip back and forth? Sorry if I'm getting this
straight away :)

> - please be sure this mode only happens when there is actually something to
> be moved

Sorry, my mistake. Fixed.

Aron

>
> best regards
> Casper
>
> ----- Original Message -----
> From: "Aron Stansvik" <elvstone@gmail.com>
> To: "For developer's discussion about KOffice" <koffice-devel@kde.org>
> Sent: Thursday, January 17, 2008 11:12 PM
> Subject: Re: Precision "display mode" for KoRuler
>
>
> > Hi everybody.
> >
> > Attached is a patch for this feature for review. Please try it out.
> > The actual activation of my display mode turned out to be more
> > complicated than I thought, with no really elegant solution, but after
> > having discussed it a bit in #koffice with Casper and others, we
> > decided this was the least ugly way to do it.
> >
> > It only implements this feature for the horizontal rulers so far, as
> > the margins in the ruler can't be moved yet I had no way to test it
> > for the vertical one. Maybe I'll look into fixing moving of the
> > margins.
> >
> > Typing this from a buzzing KDE 4.0 release event in Mountain View,
> > very exciting :)
> >
> > Take care,
> > Aron
> >
> > 2007/11/3, Thomas Zander <zander@kde.org>:
> >> On Saturday 03 November 2007 12:24:35 Aron Stansvik wrote:
> >> > I think this is pure genius :) Thomas?
> >>
> >> Agreed
> >>
> >> --
> >> Thomas Zander
> >>
> >> _______________________________________________
> >> koffice-devel mailing list
> >> koffice-devel@kde.org
> >> https://mail.kde.org/mailman/listinfo/koffice-devel
> >>
> >>
> >>
> >
>
>
> --------------------------------------------------------------------------------
>
>
> > _______________________________________________
> > koffice-devel mailing list
> > koffice-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/koffice-devel
> >
>
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@kde.org
> https://mail.kde.org/mailman/listinfo/koffice-devel
>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]