[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: kspread assembly compile failure
From:       Bongani Hlope <bhlope () mweb ! co ! za>
Date:       2007-11-23 22:39:16
Message-ID: 200711240039.16471.bhlope () mweb ! co ! za
[Download RAW message or body]

On Friday 23 November 2007 13:22:51 Jonathan Riddell wrote:
> KOffice fails to build on powerpc and other arches due to assembly.
>
> http://launchpadlibrarian.net/10521906/buildlog_ubuntu-hardy-powerpc.koffic
>e2_1.9.95-0ubuntu1_FAILEDTOBUILD.txt.gz
> http://launchpadlibrarian.net/10522090/buildlog_ubuntu-hardy-sparc.koffice2
>_1.9.95-0ubuntu1_FAILEDTOBUILD.txt.gz
>
> /build/buildd/koffice2-1.9.95/kspread/tests/BenchmarkHelper.h: In
> function 'KSpread::Time::tval KSpread::Time::stamp()':
> /build/buildd/koffice2-1.9.95/kspread/tests/BenchmarkHelper.h:46:
> error: unknown register name 'edx' in 'asm'
> /build/buildd/koffice2-1.9.95/kspread/tests/BenchmarkHelper.h: In
> function 'KSpread::Time::tval
> KSpread::Time::elapsed(KSpread::Time::tval)':
> /build/buildd/koffice2-1.9.95/kspread/tests/BenchmarkHelper.h:53:
> error: unknown register name 'edx' in 'asm'
>

Which seems really silly to have in an office package.... The edx is also not 
needed there because it is not used, it should be asm volatile("rdtsc" : "=a" 
(tsc));

But it should be moved to an architecture dependent files e.g. 
tests/arch/x86/BenchmarkHelper.h

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]