[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: cleaning up KGlobalSettings deprecations
From:       Stefan Nikolaus <stefan.nikolaus () kdemail ! net>
Date:       2007-09-01 13:02:47
Message-ID: 200709011502.52095.stefan.nikolaus () kdemail ! net
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 31 August 2007 23:35:44 Matthew Woehlke wrote:
> koffice/libs/guiutils/KoTooluButton.cpp:811 uses (in fact, is the only
> user of) KGlobalSettings::toolBarHighlightColor, which is deprecated.
> After talking with winterz I guess we're going to try to remove all this
> stuff for KDE4.0 final. However, aside from not having koffice checked
> out, I'm not even sure what this code is supposed to be doing. Anyone
> have suggestions for how to get rid of it?

KoTooluButton.h is neither included anywhere in koffice, nor is 
KoTooluButton.cpp compiled. It wasn't really used in the 1.6 branch, just in 
a test. To verify my grep: lxr spits out anything for the classes in 
KoTooluButton.h (KoColorPanel, KoColorPopupProxy and KoToolButton) except the 
usual hits in the header and its corresponding source file. I'd say, it's 
okay to ignore or even remove it.

Regards,
Stefan

["signature.asc" (application/pgp-signature)]

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]