[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/libs/flake
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2007-07-30 11:51:14
Message-ID: 200707301351.14440.t.zachmann () zagge ! de
[Download RAW message or body]

Hello Thomas,

please revert this patch as it does not work as it should. There is a good 
reason the code was the way it was. The problem is that the tool does not get 
notified when a shape is deleted. To see the problem:

1. select more then one object
2. select all points of one object
3. delete the points 

with your patch the points of the deleted object are still visible. Without 
your patch it works as it should.

Have a nice day,

Thorsten

PS: I won't be around the next days so a response can take some time.


On Monday 30 July 2007, Thomas Zander wrote:
> SVN commit 694212 by zander:
>
> Don't ask the selection each and every time we need the items we are
> working on, with all the dynamic casts and checks, just do that one time at
> activation and store the results.
> This fixes the problem that if you had a shape as a child of a group, you
> could only partly edit it due to inconsistent calls to the
> currentSelection()
>
>
>  M  +67 -122   KoPathTool.cpp
>  M  +1 -0      KoPathTool.h
>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]