[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: koffice/shapes/text/tests
From: Pinaraf <pinaraf () gmail ! com>
Date: 2007-06-05 11:52:26
Message-ID: 2d74a35c0706050452n3502ec3at4ad89c3719e7d6b4 () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Sorry, I can't be on IRC when I'm at work. But I'm quite often on IRC,
nickname Pinaraf....
I can't look at this right now, it's gonna wait until I go back home.
On 6/5/07, Thomas Zander <zander@kde.org> wrote:
>
> On Monday 04 June 2007 23:30:15 Sebastian Sauer wrote:
> > On Monday 04 June 2007, Thomas Zander wrote:
> > > On Monday 28 May 2007 23:04:51 Pierre Ducroquet wrote:
> > >
> > >
> > > Can you explain how you got to that conclusion?
> > > I don't think that the paragraph-borders can fall outside the text
> > > shape, which happens when you ignore them and only use the padding.
> > >
> > > In other words; I think the previous one was right which added both,
> > > why do you think otherwise?
> >
> > uhm... guess it was more me that was thinking that the testcase itself
> > need to be fixed and that the introduced padding-fix was correct.
>
> Oh,
>
> basically I think that the testcase commit should be reverted since I
> wrote it the way I think it is correct and on re-reading I don't see a
> problem in how it was before the commit.
>
> This makes me wonder why the commit 668477 was made in the first place, as
> it changes behavior claiming the previous behavior is wrong.
> This is commit:
> "Fixes padding... This has been tested with the ODF test case for
> padding."
>
> I'd like to know what was wrong first and what you think it should be (and
> why!).
> Is Pierre ever on IRC? Would be easier to talk there...
> --
> Thomas Zander
>
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@kde.org
> https://mail.kde.org/mailman/listinfo/koffice-devel
>
>
>
[Attachment #5 (text/html)]
Sorry, I can't be on IRC when I'm at work. But I'm quite often on IRC, \
nickname Pinaraf....<br>I can't look at this right now, it's gonna wait until \
I go back home.<br><br><div><span class="gmail_quote"> On 6/5/07, <b \
class="gmail_sendername">Thomas Zander</b> <<a \
href="mailto:zander@kde.org">zander@kde.org</a>> wrote:</span><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"> On Monday 04 June 2007 23:30:15 Sebastian Sauer \
wrote:<br>> On Monday 04 June 2007, Thomas Zander wrote:<br>> > On Monday 28 \
May 2007 23:04:51 Pierre Ducroquet wrote:<br>> ><br>> ><br>> > Can \
you explain how you got to that conclusion? <br>> > I don't think that the \
paragraph-borders can fall outside the text<br>> > shape, which happens when \
you ignore them and only use the padding.<br>> ><br>> > In other words; I \
think the previous one was right which added both, <br>> > why do you think \
otherwise?<br>><br>> uhm... guess it was more me that was thinking that the \
testcase itself<br>> need to be fixed and that the introduced padding-fix was \
correct.<br><br>Oh,<br><br> basically I think that the testcase commit should be \
reverted since I<br>wrote it the way I think it is correct and on re-reading I \
don't see a<br>problem in how it was before the commit.<br><br>This makes me \
wonder why the commit 668477 was made in the first place, as <br>it changes behavior \
claiming the previous behavior is wrong.<br>This is commit:<br> "Fixes \
padding... This has been tested with the ODF test case \
for<br> padding."<br><br>I'd like to know what was wrong first \
and what you think it should be (and <br>why!).<br>Is Pierre ever on \
IRC? Would be easier to talk there...<br>--<br>Thomas \
Zander<br><br>_______________________________________________<br>koffice-devel \
mailing list<br><a href="mailto:koffice-devel@kde.org"> \
koffice-devel@kde.org</a><br><a \
href="https://mail.kde.org/mailman/listinfo/koffice-devel">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br><br><br></blockquote></div><br>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic