[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Notes on koffice unit tests
From:       Jaham <jaham () gmx ! net>
Date:       2007-02-11 23:45:17
Message-ID: 200702120045.17699.jaham () gmx ! net
[Download RAW message or body]

On Sunday, 11. February 2007 22:22, Thomas Zander wrote:
> On Sunday 11 February 2007 18:12, Jaham wrote:
> > > I wrote that test after I saw people altered flake to do things
> > > incorrectly. I was hoping someone would fix their mistake (I recall
> > > emailing about it) but nobody did.
> >
> > Can you possibly point me to the mail you wrote?
>
> I just looked. Can't find it in my sent box.

Yeah i searched the archives and could not find that mail either. :-)

>
> I probably meant to put it on my own TODO list and then promptly forgot to
> do so :)

I know that. A soon as one wants to move an item from ones mental list to a 
one on disk or paper it magically disappears from consciousness. :-D

>
> The basic things that is going wrong now is that drawing of nested shapes
> is done by the shapeManager.  While my idea was to let them be painted by
> the shapeConnection.  Direct effect; they are painted twice.  And in
> different places as well.
>

Don't know what you mean by shapeConnection. You probably mean the shape 
containers? 
Please correct me if i am wrong, but i understand it that only shapes without 
a parent (top level shapes) are painted from the shape manager, all child 
shapes are painted from their parents respectively. That would fix the 
painting of hidden shapes, because painting is done hierarchically.

> If you are interrested in the details; the unit test has more.

Your comments inside the test code say that unclipped shapes should be painted 
by the shape manager, clipped ones from the shapes parent container. So 
uncommenting lines 97,98 in KoShapeContainer.cpp will fix the first painting 
test. But that will not fix the painting of hidden shapes. For that case the 
shape manager has to go up all nesting levels of a particular shape to see if 
the shape is visible or not. My proposal from above would solve that already.

What do you think?
>
> I'll put it on my TODO list for real now ;)
:-)
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]