--===============1668325569==
Content-Type: multipart/signed;
  boundary="nextPart6615252.ajjb7uREaq";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart6615252.ajjb7uREaq
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi Sascha,

On Sunday, December 17, 2006 08:14:57 PM Sascha Pfau wrote:
> another patch for a missing function. this time datedif is it. i know the
> calcution looks strange and the patch ugly. the doctumentation is missing
> too.

Cool. :)

I had a look at your patch and the logic seems okay to me. But I found some=
=20
points, where it needs improvement before commitment:
1. The reference date (date0) should be retrieved from Doc.
2. The constraint, that the first date has to be equal or greater than the=
=20
second one, should be lifted. The OpenFormula spec does not note this=20
constraint. Is it possible to exchange the dates and adjust the sign of the=
=20
return value appropriately for this case?
3. The interval parameter should be validated before calculation.
4. The documentation should at least be extended by the possible values for=
=20
the last argument, which defines the return value.

Would you be so kind and resolve these small issues?=20

Are you planning to work on KDE for a somewhat longer time? If so, please r=
ead=20
http://developer.kde.org/joining/applysvnaccount.php. If not, keep on sendi=
ng=20
patches to this list, please. :)

A place in the "Thanks to" section of KSpread's about dialog is already you=
rs,=20
if you sent us an improved version of the DATEDIF patch. ;)

Regards,
Stefan

--nextPart6615252.ajjb7uREaq
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQBFhqNTpfDn2DABIpcRAl/ZAKCDSQvBG5FUOdZKp2KG858Puj3G6QCgkRS8
BSvIS/qDltqrRw96qIzg6gQ=
=xSge
-----END PGP SIGNATURE-----

--nextPart6615252.ajjb7uREaq--

--===============1668325569==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

--===============1668325569==--