From koffice-devel  Thu Dec 14 15:38:25 2006
From: Stefan Nikolaus <stefan.nikolaus () kdemail ! net>
Date: Thu, 14 Dec 2006 15:38:25 +0000
To: koffice-devel
Subject: Re: patch for missing function
Message-Id: <200612141638.29502.stefan.nikolaus () kdemail ! net>
X-MARC-Message: https://marc.info/?l=koffice-devel&m=116611064925384
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============1189179229=="

--===============1189179229==
Content-Type: multipart/signed;
  boundary="nextPart22006892.SVWQgDMzKq";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart22006892.SVWQgDMzKq
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi Sascha,

On Wednesday 13 December 2006 19:04, Sascha Pfau wrote:
> i am very new to koffice. i've take a look into your todo's. i think
> implementing missing function isn't very difficult. so i sat down ans wro=
te
> IMLOG2 and IMLOG10 functioncs

Great! We always need people willing to help. :)

> , but now i don't know about how to commit my=20
> patch.

This is the right way for the first.

> i hope you take a look at it and commit it to trunk.

I had a look at your patch. You've multiplied the natural logarithm value w=
ith=20
M_LOG2El (log_2(e)) and M_LOG10El (log_10(e)), respectively. This looked=20
strange to me, so I grabbed my old Bronstein and found
log_a(z) =3D ln(z) / ln(a)
It has to be a division by M_LN2l and M_LN10l, respectively.
More detailed:
z=3Dr*exp(i*phi)
ln(z)=3Dln(r)+i*phi*ln(e)=3Dln(r)+i*phi
log2(z)=3Dln(z)/ln(2)=3Dln(r)/ln(2)+(i*phi)/ln(2)

Besides that the patch looks good. :) Your examples are correct though. ;)=
=20
Committed with the above changes.

If you're interested in implementing more functions, I'd like to point you =
to=20
the OpenFormula work. The latest spec could be found at:=20
http://www.oasis-open.org/apps/org/workgroup/office-formula/documents.php.
To figure out which functions KSpread still lacks of, you should create a t=
est=20
document out of the latest spec. The test doc generator could be found at=20
http://wiki.oasis-open.org/office/Test_Suite_Generator.
Just follow the simple instructions and open the generated test doc in=20
KSpread. This would give you a hint which functions need to be implemented.
But you can also ask for the functions. ;-)

If you're heading for something different, let us know. Either here on=20
koffice-devel or on IRC #koffice.

Regards,
Stefan

--nextPart22006892.SVWQgDMzKq
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQBFgW/1pfDn2DABIpcRAlxVAJ4/jtxzNiL2FtTd9Zd0xwcrv/ZC4ACfaHLp
cvfl4hpDPIF7sCKCcPKf9rg=
=kTY0
-----END PGP SIGNATURE-----

--nextPart22006892.SVWQgDMzKq--

--===============1189179229==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

--===============1189179229==--