[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: EBN const-ref fixes for krita and libs
From:       David Faure <faure () kde ! org>
Date:       2006-10-16 11:22:15
Message-ID: 200610161322.15997.faure () kde ! org
[Download RAW message or body]

On Sunday 15 October 2006 11:10, Thomas Zander wrote:
> This means for example that the KoUnit.cpp one (line 147) should be ignored.
Not sure about that, since the QString argument instead of a const-ref is actually
an implementation detail. If the implementation changes one day and modifying
the argument internally isn't necessary anymore, we'll still have a useless pass-by-value
parameter. Making it constref and copying to a QString variable internally should
have no noticeable cost and is more flexible to future changes.
No big deal in any case, though.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]