[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: KSpread Kexi Import Filter
From:       Martin Ellis <martin.ellis () kdemail ! net>
Date:       2006-08-16 19:28:50
Message-ID: 200608162028.50993.martin.ellis () kdemail ! net
[Download RAW message or body]

On Wednesday 16 August 2006 20:07, Martin Ellis wrote:
> On Wednesday 16 August 2006 19:59, Adam Pigg wrote:
> > let me know your views
>
> Just a quick comment:

And another.

I think you should use the KexiDB parser on the query string in 
kspread_kexiimport.cc, instead of:

    else if (type == "Custom") //Custom Query
    {
        cur = m_dialog->connection()->executeQuery( object );
    }

If you don't, people will find that they can't just copy and paste queries
from Kexi directly into that box.   I'm too tired to figure out if it's OK for 
the other two, right now.

(It's an awkwardness of the KexiDB API that it's easier to pass an SQL query 
directly to the DB engine, rather than use the KexiDB parser.)

Martin

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]