Patch looks good (but like you I have no previous experience with this code and no idea how to test it). Just one thing: > +    while (!m_objectHandles.isEmpty()) > +        delete m_objectHandles.takeFirst(); Please use qDeleteAll(m_objectHandles), simpler and faster. -- David Faure, faure@kde.org, sponsored by Trolltech to work on KDE, Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org). _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel