From koffice-devel  Thu May 18 13:08:24 2006
From: David Faure <faure () kde ! org>
Date: Thu, 18 May 2006 13:08:24 +0000
To: koffice-devel
Subject: Re: patch for CID 1258
Message-Id: <200605181508.24564.faure () kde ! org>
X-MARC-Message: https://marc.info/?l=koffice-devel&m=114795775023460

Patch looks good (but like you I have no previous experience with this code 
and no idea how to test it).

Just one thing:
> +    while (!m_objectHandles.isEmpty())
> +        delete m_objectHandles.takeFirst();

Please use qDeleteAll(m_objectHandles), simpler and faster.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel