[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    [PATCH] make the font dialog only change the selected parts
From:       "Benjamin K. Stuhl" <benjamin.stuhl () colorado ! edu>
Date:       2006-03-11 2:17:52
Message-ID: 20060310191752.0c956701 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


All the framework was there to make the font dialog e.g. only change
the font face but leave the size alone, but an uninitialized
variable broke it. The attached patch fixes it.

There does still seem to be a problem with undoing style changes,
though. For instance, construct a paragraph with two different
font sizes, select the paragraph and change the font size, undo the
change, and then change any other font property: the font size changes
again!

-- BKS

["kofontdia.patch" (text/x-patch)]

Index: koffice/lib/kotext/KoFontDia.cpp
===================================================================
--- koffice/lib/kotext/KoFontDia.cpp	(revision 517443)
+++ koffice/lib/kotext/KoFontDia.cpp	(working copy)
@@ -48,7 +48,8 @@
     KSpell2::Broker::Ptr broker, QWidget* parent, const char* name )
     : KDialogBase( parent, name, true,
     i18n("Select Font"), Ok|Cancel|User1|Apply, Ok ),
-    m_initialFormat(initialFormat)
+    m_initialFormat(initialFormat),
+    m_changedFlags(KoTextFormat::NoFlags)
 {
     setButtonText( KDialogBase::User1, i18n("&Reset") );
 

["signature.asc" (application/pgp-signature)]

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]