[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: kspread: non-contiguous selection
From:       Stefan Nikolaus <stefan.nikolaus () kdemail ! net>
Date:       2005-12-17 12:48:29
Message-ID: 200512171348.31718.stefan.nikolaus () kdemail ! net
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Saturday, 17. December 2005 13:32, Tomas Mecir wrote:
> On 12/17/05, Stefan Nikolaus <stefan.nikolaus@kdemail.net> wrote:
[...]
> > Reverting my last comment.
> > Canvas::slotScrollHorz() don't need to be a manipulator and there are
> > more of those. Let's agree, that each operation on cell regions should
> > become a manipulators. The others not. Okay?
>
> Yeah, it's not so obvious on things that simply move the cursor/view
> around (are these the only ones affected?).
> These indeed don't need to be manipulators, but at the very least,
> they should be somehow merged together, so that we only have ONE
> view-moving code, and only ONE cursor moving code - I think there's
> some duplication as of now.

Does it? I've touched the cursor moving code - gotoLocation() is=20
goneToLocation(nirvana). ;-) Or what do you mean exactly?

> Hence, we only get two more cases where emitBeginOperation and
> emitEndOperation are used. I want to keep occurences of this to the
> minimums, to make it easier to get rid of them when the time comes.

Well, the ones that don't work on cell regions are not so many, AFAICS.

Bye,
Stefan

[Attachment #5 (application/pgp-signature)]

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]