[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: kpresenter OASIS save patch
From:       Laurent Montel <montel () kde ! org>
Date:       2005-06-23 16:46:34
Message-ID: 200506231846.35116.montel () kde ! org
[Download RAW message or body]

On Wednesday 22 June 2005 08:37, Thorsten Zachmann wrote:
> Hello all,
>
> I have been reworking the oasis saving code of kpresenter to fix some bugs.
> The major change is that now saving of the style and the objects itself is
> separated. This makes the code more maintainable.
>
> Errors that are fixed by the patch
> *line: line ends of vertical lines are now saved correctly
>        rotation of lines is now saved
>
> *arc/pie/chord: with startangle = 0 are save correctly now.
>
> * the style of the line obejcts and KPPointObjects which are on the master
> page are now saved in the styles file.
>
> I still have a question about the objects we are up to now are not saving
> in oasis. Is it ok to save the objectpartly (only position and name but not
> the how the e.g bezier curve looks like? Or should I save nothing for
> objects we do not support up to now? What do you think is better?
>
> Please let me know what you think about the attached patch. The patch is
> against koffice 1.4.
>
> I really like to get the patch in as soon as possible, so that merging it
> to trunk is still easy before to many commits go to trunk.
>
> I know that there are still a lot of problems with the oasis saving and
> loading. I will have a look at those problems after the patch is committed.
>
> Have a nice day,


Hi,
I don't understand why you change it ?
-QString KPPointObject::saveOasisStrokeElement( KoGenStyles& mainStyles ) 
const
+bool KPPointObject::saveOasisObjectAttributes( KPOasisSaveParameter &sp ) 
const
 {
-    KoGenStyle styleobjectauto( KoGenStyle::STYLE_GRAPHICAUTO, "graphic" );
-    saveOasisMarkerElement( mainStyles, styleobjectauto );
-    saveOasisObjectProtectStyle( styleobjectauto );
-    KPShadowObject::saveOasisStrokeElement( mainStyles, styleobjectauto );
-    return mainStyles.lookup( styleobjectauto, "gr" );
+    kdDebug()<<"bool 
KPAutoformObject::saveOasisObjectAttributes( KPOasisSaveParameter &sp ) not 
implemented\n";
+    return true;
 }

it's not a KPAutoformObject and KPShadowObject saved very well it.

Regards.
PS: for the moment I can't test your patch because I install my name amd64 
machine

> Thorsten
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]