[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] KWord: ruler's new look
From:       Yann Bodson <yann.bodson () online ! fr>
Date:       2005-05-23 7:28:52
Message-ID: 200505231728.52742.yann.bodson () online ! fr
[Download RAW message or body]

On Mon, 23 May 2005 04:55 pm, Thomas Zander wrote:

> These certainly look good; great work!
Thank you.

> What happens when th toolBarFont is a 20pt font? Does the ruler-size grow?
> If not then that should be done before removing the setter to 8pt.
No. The rulers have a fixed size. But I persist to think that my solution is 
better because you can always adjust the size in the font properties. The 
hard-coded size of 8pt is just wrong. With some 16:10 screens with strange 
dpi, the rulers are completely unreadable and there is currently no way to 
change that.

> I object to this change though, the smaller lines and even smaller dots are
> not great for people with less eye sight.  Its not a good idea to make
> something unusable in order to make it nicer looking :)
> So please revert this; or show us another proposal.
OK, it's maybe too small. But the original ones were way too big :)
I think we can agree on the middle solution.

> Question; where did the ruler png's come from?  Can you claim full
> copyright, or are they copies from somewhere else?
Yep. I've done it myself with the gimp.
But I admit they are heavily inspired by the ones from OOo 2.0. :)

> Also; the marker has a pointer (or head if you will) of 2 pixels, which
> makes it pretty hard to mark something precise. It would be better if it
> had a point of 1 pixel width.
That's an interesting point, because I first made markers with 1 pixel width. 
It was impossible to place them exactly due to rounding problems in the code. 
I realized that the original ones had 2 pixels width so I changed my 
markers...
I will examine this more closely.

Thanks for your feedback.

-- 
Yann
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]