[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] KWord: ruler's new look
From:       Thomas Zander <zander () kde ! org>
Date:       2005-05-23 6:55:02
Message-ID: 200505230855.08017.zander () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 23 May 2005 01:00, Yann Bodson wrote:
> I've done some work on kword's rulers this week-end.
>
> Changes:
> - FrameStyle changed from Box-Raised to MenuBarPanel (less cluttered
> IMHO) 
> - Using KGlobalSettings::toolBarFont() instead of hardcoded 8 sized font.
> - Using KGlobalSettings::textColor() instead of black. So rulers are
> readable even with dark colors themes.
> - New indents triangles pixmaps

These certainly look good; great work!
What happens when th toolBarFont is a 20pt font? Does the ruler-size grow? 
If not then that should be done before removing the setter to 8pt.

> - Ruler lines are smaller. 
I object to this change though, the smaller lines and even smaller dots are 
not great for people with less eye sight.  Its not a good idea to make 
something unusable in order to make it nicer looking :)
So please revert this; or show us another proposal.

Question; where did the ruler png's come from?  Can you claim full 
copyright, or are they copies from somewhere else?
Also; the marker has a pointer (or head if you will) of 2 pixels, which 
makes it pretty hard to mark something precise. It would be better if it 
had a point of 1 pixel width.

-- 
Thomas Zander

[Attachment #5 (application/pgp-signature)]

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]