[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/kpresenter
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2005-04-26 10:21:46
Message-ID: 200504261221.46951.t.zachmann () zagge ! de
[Download RAW message or body]

Hello Mashrab,

On Tuesday 26 April 2005 11:06, Mashrab Kuvatov wrote:
> Hi Thorsten,
>
> On Tuesday 26 April 2005 06:07, you wrote:
> > Hello Mashrab,
> >
> > I haven't tested your patch yet, But here is a small note
> >
> > >      delete m_spell.dlg;
> > > +    m_spell.dlg = 0L;
> > >      m_spell.dlg = new KSpell2::Dialog( m_spell.kospell, this );
> >
> > You don't need to set m_spell.dlg to 0 before you do a new directly
> > afterwards.
>
> OK. If it is redundant, shell I remove it?

Yes please.

> > >      if ( m_spell.macroCmdSpellCheck )
> > > @@ -4696,8 +4695,7 @@ void KPresenterView::spellCheckerDone( c
> > >  {
> > >  #ifdef HAVE_LIBKSPELL2
> > > -    //kdDebug(32001) << "KWView::spellCheckerDone" << endl;
> > > -    KoTextObject* textobj = m_spell.kospell->currentTextObject();
> > > -    Q_ASSERT( textobj );
> > > -    KPrTextDocument *textdoc=static_cast<KPrTextDocument *>(
> > > textobj->textDocument() ); +    /* See also KWView::spellCheckerDone
> > > from KWord */
> > > +    kdDebug() << "KPresenterView::spellCheckerDone" << endl;
> > > +    KPrTextDocument *textdoc=static_cast<KPrTextDocument *>(
> > > m_spell.kospell->textDocument() ); Q_ASSERT( textdoc );
> > >      if ( textdoc )
> >
> > Can you please put the Q_ASSERT to its own line. This makes it more
> > readable.
>
> It is on the new line. Look at the code.

My fault then :-).

Have a nice day,

Thorsten 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]