[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: KPresenter crashes on spellchecker (patch included)
From:       David Faure <faure () kde ! org>
Date:       2005-04-25 16:39:35
Message-ID: 200504251839.36645.faure () kde ! org
[Download RAW message or body]

On Monday 25 April 2005 18:35, Mashrab Kuvatov wrote:
> On Monday 25 April 2005 18:10, David Faure wrote:
> > Your previous patch (the
> > one that includes a kspell2 change) looks fine to me from the koffice side,
> > but I don't know the kspell2 API enough to be able to comment on the
> > kspell2 side of things, so I'm waiting for Zack to answer.
> 
> OK. I do not think it will break anything. Only KOffice is using KSpell2,
> right? 
AFAIK, yes.

> If Zack accepts it, we have to backport it to older versions of 
> kdelibs, don't we?
Yes.

> I did it this way to ease the revision of the patch. This way it is clear what
> and why is done.
That's what CVS is for. We don't leave this kind of comment each time, it would be messy :)

> Do you give me a green light to commit?
Yes.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]