[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Bug in koZipStore?
From:       David Faure <faure () kde ! org>
Date:       2005-04-14 21:23:50
Message-ID: 200504142323.51342.faure () kde ! org
[Download RAW message or body]

On Thursday 14 April 2005 21:32, Boudewijn Rempt wrote:
> I couldn't open read-only images even for reading in Krita anymore.
> 
> I guess the check on the writability of a directory isn't needed if you
> open a file just for Reading. But maybe there's a subtle reason why the 
> following fixlet is wrong:
> Index: koZipStore.cc
> 
> ===================================================================
> RCS file: /home/kde/koffice/lib/store/koZipStore.cc,v
> retrieving revision 1.23
> diff -u -3 -u -p -r1.23 koZipStore.cc
> --- koZipStore.cc       31 Mar 2005 12:33:13 -0000      1.23
> +++ koZipStore.cc       14 Apr 2005 19:31:44 -0000
> @@ -43,7 +43,7 @@ KoZipStore::KoZipStore( const QString &
>      // Workaround for KZip KSaveFile double deletion in kdelibs-3.4,
>      // when trying to write to a non-writable directory.
>      QDir dir( QFileInfo( _filename ).dir() );
> -    if ( !QFileInfo( dir.path() ).isWritable() )
> +    if (_mode == Write && !QFileInfo( dir.path() ).isWritable()  )

Looks fine, please commit.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]