[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review of one of my fixes, please?
From:       Inge Wallin <inge () lysator ! liu ! se>
Date:       2005-03-19 22:42:49
Message-ID: 200503192342.50655.inge () lysator ! liu ! se
[Download RAW message or body]

Hi,

I just managed to fix the long standing bug 
http://bugs.kde.org/show_bug.cgi?id=63332 (pasting into one cell that has 
long text pastes into several cells).

However, I am not sure about my fix.  Can one of you old hands take a look?

The problem turned out to be that the selection is always extended to all 
cells that are obscured by the selected cell. I made this optional, which in 
itself shouldn't be dangerous since the old behaviour is still the default.  
However, in KSpreadSelection::extendToMergedAreas(), there is a comment that 
says:

> if just a single cell is selected, we need to merge even when
> the obscuring isn't forced.  But onliy if this is the cell that
> is doing the obscuring -- we still want to be able to click on a cell
> that is being obscured.

Why is that?  I don't understand the comment.  Why would we *need* to merge? I 
suspect that this is something that is left behind from a previous 
implementation of something. But what?

I suggest that either it is further explained in the comment, or it is 
removed.

 -Inge


-- 
Inge Wallin               | Thus spake the master programmer:               |
                          |      "After three days without programming,     |
inge@lysator.liu.se       |       life becomes meaningless."                |
                          | Geoffrey James: The Tao of Programming.         |
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]