[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] KConfig XT and koshell
From:       Aaron Seigo <aseigo () kde ! org>
Date:       2005-02-18 21:07:58
Message-ID: 200502181408.08157.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On February 18, 2005 14:01, Sven Lüppken wrote:
> Can anybody help me with that KConfig XT stuff? :) There's some mistake
> I don't see at the moment :}

+void KoShellWindow::saveSettings()
+{
+  KoShellSettings::setSidebarWidth( m_pKoolBar->width() );     
     KoShellSettings::writeConfig();
+}
 
as an aside, why bother keeping m_width around at all? just access 
KoShellSettings::sidebarWidth() everywhere. save yourself have to sync the 
two values and save a whopping whole sizeof(bool) of memory ;P 

i do find it makes the code a bit more readable though. and easier to keep in 
sync with the kcfg file since everywhere you rely on those settings becomes 
pretty obvious, even if you use them from multiple locations in the code. 
just one thing to grep for =)

-- 
Aaron J. Seigo
Society is Geometric

[Attachment #5 (application/pgp-signature)]

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]