[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] broken Table of Contents
From:       Raphael Langerhorst <raphael-langerhorst () gmx ! at>
Date:       2005-02-07 6:23:25
Message-ID: 200502070723.26218.raphael-langerhorst () gmx ! at
[Download RAW message or body]

On Sunday 06 February 2005 21:54, David Faure wrote:
> On Thursday 03 February 2005 18:22, Raphael Langerhorst wrote:
> > Hi all,
> >
> > maybe some of you noticed, the table of contents puts
> > the page numbers ON THE NEXT LINE, which looks
> > a bit ugly (not acceptable).
>
> Indeed.
>
> > A short problem analysis: the tab (for the page numbers)
> > gets set on a certain position and is "right aligned", so
> > the text (page numbers) expand to the left. But the new
> > line character is STILL on the RIGHT side of the tabulator.
>
> Yes, and the line-breaking formatter decided to break the line for
> that reason, which is obviously wrong thinking on its part :)
>
> > My patch is a workaround I guess. But this would need well
> > considered KoText modifications. If anyone wants to have
> > a go, then please.
>
> Done.

ok, great!

>
> > Let me know if I should commit, or if anyone decides to fix
> > KoText instead. (I won't commit until I get a positive answer)
>
> Hmm, I didn't see any positive answer, and I see you committed
> nonetheless :-) No matter, all fixed now. Thanks for bringing this
> to my attention.

yes, sorry, I had a bad feeling about it anyway, I cc'd the 
koffice-devel mailing list with the commit log, which explains a bit.

Thanks a lot for fixing it all together :)

Raphael
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]