[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/filters/kspread/gnumeric
From:       Nikolas Zimmermann <wildfox () kde ! org>
Date:       2005-02-01 22:23:31
Message-ID: 200502012323.31564.wildfox () kde ! org
[Download RAW message or body]

On Tuesday 01 February 2005 21:19, Laurent Montel wrote:
> CVS commit by mlaurent:
>
> Export area name
> TODO import area name
[snip]
> +    if ( ksdoc->listArea().count()>0 )
> +    {
> +        QDomElement areaNames = gnumeric_doc.createElement("gmr:Names");
> +        QValueList<Reference>::Iterator it;
> +        QValueList<Reference>::Iterator itbegin;
> +        QValueList<Reference> area =ksdoc->listArea();
> +        itbegin=area.begin();
> +        QValueList<Reference>::Iterator itend( area.end() );
> +        for ( it = itbegin; it != itend; ++it )
Hi Laurent, 
that's looks really unconsitent - better make it:
QValueList<Reference> &area = ksdoc->listtArea(); // copying by value is slow!
QValueList<Reference>::ConstIterator it = area.begin();
QValueList<Reference>::ConstIterator end = area.end();
for(; it != end; ++it)
...


Bye
 Bye
  Niko
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]