[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: possible configure problem for krita
From:       Tomas Mecir <mecirt () gmail ! com>
Date:       2004-12-17 13:36:10
Message-ID: 492258b10412170536355893f8 () mail ! gmail ! com
[Download RAW message or body]

On Fri, 17 Dec 2004 14:24:23 +0100, Boudewijn Rempt <boud@valdyas.org> wrote:

Yup, that looks fine, although there's some unnecessary code duplication...
You may want to move the check for lcms/lcms.h straight before the
echo "#include ..." line, with only these two echos being in the if
and else branches. The check for lcms.h is not needed then, as you can
simply assume that you can do <#include <lcms.h> if there's no
lcms/lcms.h, maybe there's no such header still, but then the
compilation will fail, giving you the same result that you'd get for
lcms <= 1.13.
Nothing of this isn't really needed, but it might save you some
trouble later on, with the duplicate checks and stuff ...

/ Tomas
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]