[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [patch]Bug 50138: copy paste images throughout
From:       David Faure <faure () kde ! org>
Date:       2004-12-01 22:25:34
Message-ID: 200412012325.34640.faure () kde ! org
[Download RAW message or body]

On Wednesday 01 December 2004 23:10, Sven Langkamp wrote:
> I ported the image drop code from KPresenter to KWord to fix bug 50138.
> Patch is attached.
Looks good to me.

Except  KMimeMagic::self()->findFileType which is deprecated and replaced
with KMimeType::findByFileContent() (since 2001 so this should be fine).

Also, this bit can be simplified:
+            QString filename;
+            if ( !url.isLocalFile() ) {
+                if ( !KIO::NetAccess::download( url, filename, this ) )
+                    continue;
+            } else {
+                filename = url.path();
+            }
NetAccess::download does the right thing for local files, so this could be simply
+                if ( !KIO::NetAccess::download( url, filename, this ) )
+                    continue;

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]