[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: koffice/lib/kofficecore [POSSIBLY UNSAFE]
From: David Faure <faure () kde ! org>
Date: 2004-11-13 0:01:25
Message-ID: 20041113000125.BDFF016CD1 () office ! kde ! org
[Download RAW message or body]
CVS commit by faure:
Before:
for ( QDomNode n = styles.firstChild(); !n.isNull(); n = n.nextSibling() )
{
const QDomElement e = n.toElement();
if ( e.isNull() ) continue;
insertStyle( e );
}
After:
QDomElement e;
forEachElement( e, styles )
insertStyle( e );
Looks nice, doesn't it? :)
Everyone writing OASIS-loading code: please take also a look at kodom.h; I explain
in there how to write proper namespace-aware QDom code... we should have done
this from the start instead of hardcoding prefixes [which is OK on saving, but
not on loading].
This is a nice JJ: help porting the code to be namespace-aware, following the
instructions in kodom.h
My next step is KoStyleStack's API. Feel free to start on the apps themselves.
CCMAIL: koffice-devel@kde.org
M +49 -44 koOasisSettings.cc 1.7
M +100 -136 koOasisStyles.cc 1.13
M +5 -2 koStyleStack.cc 1.16
M +26 -0 kodom.h 1.3
M +38 -2 tests/kodomtest.cpp 1.2 [POSSIBLY UNSAFE: qDebug]
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic