[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [patch] initDoc in koffice/example usage
From:       David Faure <faure () kde ! org>
Date:       2004-09-17 12:37:29
Message-ID: 200409171437.29681.faure () kde ! org
[Download RAW message or body]

On Friday 17 September 2004 14:27, Brad Hards wrote:
> Is this patch correct? 
> 
> retrieving revision 1.19
> diff -u -4 -p -r1.19 example_part.cc
> --- example_part.cc     12 Sep 2004 11:53:55 -0000      1.19
> +++ example_part.cc     17 Sep 2004 12:25:52 -0000
> @@ -34,9 +34,9 @@ bool ExamplePart::initDoc(InitDocFlags f
>      // If nothing is loaded, do initialize here
>      // Most KOffice applications use the template dialog here, with code 
> like:
>  /*
>      KoTemplateChooseDia::DialogType dlgtype;
> -    if (initDocFlags() != KoDocument::InitDocFileNew )
> +    if (flags != KoDocument::InitDocFileNew )
>          dlgtype = KoTemplateChooseDia::Everything;
>      else
>          dlgtype = KoTemplateChooseDia::OnlyTemplates;

Yes.

While you're at it, please make sure InitDocEmpty is handled, and parentWidget
is passed to KoTemplateChooseDia::choose() :)

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]