[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] : findStyleShortcut changed to findStyleByShortcut
From:       David Faure <faure () kde ! org>
Date:       2004-08-23 10:13:31
Message-ID: 200408231213.31766.faure () kde ! org
[Download RAW message or body]

On Monday 23 August 2004 09:06, p.stirnweiss_koffice@bluewin.ch wrote:
> Hello,
> 
> This patch renames all instances of the function styleFindShortcut to findStyleByShortcut
> as requested in the koStyle.cc (a todo).
> The patch applies to koffice dir. The code compiles and KWord seems to run
> OK so I guess I haven't missed any 

Looks good, please commit. 

> (used the grep of KDevelop to find all 
> instancies, really good tool this KDevelop).
:)

While you're are it, in that file, "translated" should become "display",
"Template" could be removed (addStyleTemplate should be addStyle),
and the find functions are not clear.
(e.g. findTranslatedStyle should become findStyleByDisplayName)

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]