[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [patch] Re: Presentation duration display
From:       David Faure <faure () kde ! org>
Date:       2004-05-02 12:08:58
Message-ID: 200405021408.58720.faure () kde ! org
[Download RAW message or body]

On Sunday 02 May 2004 03:13, Brad Hards wrote:
> On Fri, 30 Apr 2004 10:03 pm, David Faure wrote:
> > Well, it looks like it works then, there are no more complex cases than
> > those two (except that Singapur has TimeFormat=%p %H:%M:%S so the removal
> > of %p (am/pm) will lead to a leading space... no big deal though). I'll
> > commit.
> I've incorporated this, and the changes to the labels, and not displaying
> slides that are disabled, which is my understanding of the rough concensus.
Yes.

> Adding functionality so that if you click on the slide title is going to be a
> bit trickier (I'm guessing I need to subclass KListViewItem and reimplement
> activated() or something like that). So that has to wait.
No, you can simply connect to KListView's executed(QListViewItem*) signal.

> +// in kdelibs 3.2.90, an additional method was added that basically
> +// allows formatting of time as a duration. Before this, you can get
> +// weirdness (such as a duration of 12:00:03 am) depending on how the
> +// time format is set.
Ah. I thought you'd use QTime or manual formatting for kdelibs-3.2, but in fact
this doesn't matter at all - temporary code in cvs head doesn't have to be perfect.

> +    slides->addColumn( i18n( "No." ) );
Is No. a standard abbreviation in English for number? Isn't it rather Nr.?
It's a bit strange since there's no "o" in number (as there is in French)....
Anyway I guess the same label should be used as the one used in other
places of kpresenter - e.g. the web-export dialog.

Looks ok anyway, feel free to commit.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]