[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Presentation duration display
From:       Brad Hards <bhards () bigpond ! net ! au>
Date:       2004-04-30 12:11:55
Message-ID: 200404302211.55566.bhards () bigpond ! net ! au
[Download RAW message or body]

On Fri, 30 Apr 2004 19:12, Karl-Heinz Zimmer wrote:
> Am Freitag, 30. April 2004 10:58 schrieb Brad Hards:
> > I've become annoyed with the time display in the presentation duration
> > dialog.
> >
> > If you aren't familiar with it, see screenie at
> > http://www.cuneata.net/duration.png
> >
> > Slide time shouldn't be localised IMHO - it makes no sense to have a
> > duration of 12:00:04am
>
> ACK.  To me this looks like a bug.
>
> > I'm thinking just a straight display in seconds, or perhaps minutes and
> > seconds. The total could be in hours, minutes and seconds if I can find
> > some way to display it - my concern is over translation. I'm not sure
> > what the impact is going to be yet.
> >
> > I'm also thinking that we shouldn't display a time for slides that were
> > disabled (and hence not shown in any case). Either don't display them at
> > all, or have the name with i18n("disabled") next to it.
> >
> > Thoughts?
>
> Perhaps the disabled slides could be shown in another color?
> kind of 'grayed out'?
I tried ->setEnabled(false) but the visual effect was bad, because it grays
the background. That looks confusing with some of the backgrounds
in grey, some in white, and no correlation with the foreground. I think
it is cleaner not to display times for slides that weren't in the 
actual presentation. Is this patch OK?

RCS file: /home/kde/koffice/kpresenter/presdurationdia.cc,v
retrieving revision 1.10
diff -u -4 -p -r1.10 presdurationdia.cc
--- presdurationdia.cc  3 Jan 2004 06:58:45 -0000       1.10
+++ presdurationdia.cc  30 Apr 2004 12:04:51 -0000
@@ -67,13 +67,15 @@ void KPPresDurationDia::setupSlideList(
     slides->setRootIsDecorated( false );
     slides->setSorting( -1 );

     for ( int i = doc->getPageNums() - 1; i >= 0; --i ) {
-        KListViewItem *item = new KListViewItem( slides );
-        item->setPixmap( 0, KPBarIcon( "newslide" ) );
-        item->setText( 0, QString( "%1" ).arg( i + 1 ) );
-        item->setText( 1, *m_durationListString.at( i ) );
-        item->setText( 2, doc->pageList().at( i )->pageTitle( i18n( "Slide %1" ).arg( i + 1 ) ) );
+        if ( doc->pageList().at( i )->isSlideSelected() ) {
+            KListViewItem *item = new KListViewItem( slides );
+            item->setPixmap( 0, KPBarIcon( "newslide" ) );
+            item->setText( 0, QString( "%1" ).arg( i + 1 ) );
+            item->setText( 1, *m_durationListString.at( i ) );
+            item->setText( 2, doc->pageList().at( i )->pageTitle( i18n( "Slide %1" ).arg( i + 1 ) ) );
+        }
     }
 }

 #include "presdurationdia.moc"

> Also perhaps the column titles should be changed: instead of
> "Slide No.", "Slide time", "Slide title" there could be just
> "No.", "Duration", "Title"  -  or was there a special reason
> to repeat the word "Slide" three times?
I have played with it - the titles look a bit sparse with just
single words. How about this:

 void KPPresDurationDia::setupSlideList( QWidget *_page )
 {
     slides = new KListView( _page );
-    slides->addColumn( i18n( "Slide No." ) );
-    slides->addColumn( i18n( "Slide Time" ) );
+    slides->addColumn( i18n( "No." ) );
+    slides->addColumn( i18n( "Display Duration" ) );
     slides->addColumn( i18n( "Slide Title" ) );
     slides->header()->setMovingEnabled( false );


Brad
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]