[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Precision (Re: koffice/kpresenter)
From:       Thomas Zander <zander () kde ! org>
Date:       2004-04-25 8:42:36
Message-ID: 200404251042.41047.zander () kde ! org
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 24 April 2004 19:37, David Faure wrote:
> On Saturday 24 April 2004 08:57, Thomas Zander wrote:
> > Solution 4:
> > add to KoXMLWriter addAttribute a signature like:
> > addAttribute(String, KoUnit);
>
> Can't be done that way, since KoUnit is in kofficecore.
> But we could have
> static QString KoUnit::unitToStringValue(double, KoUnit::Unit)
> or to make it clear that the result includes the unit, unlike
> unitToUserValue, static QString KoUnit::unitToFileValue(double,
> KoUnit::Unit)

This kind of method does not seem right on koUnit, you're placing 
intelligence that belongs in the store on the unit (the fact that 'pt' is 
used to follow the unit).
If you can't reference the unit from the store (I guess you don't want the 
libkstore to depend on libkofficecore ?), then my answer to this:

> Everyone ok with xmlWriter.addAttributePt() then?

is yes, this is a good enough solution :)

- -- 
Thomas Zander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAi3oACojCW6H2z/QRAhrnAJ97AY2cvvakLDXv/T42xA2NfGXf7wCcCpMT
YUF/gMmeDP+XE4OYEIWJY+g=
=hQwW
-----END PGP SIGNATURE-----
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]