From koffice-devel Tue Feb 24 18:00:29 2004 From: David Faure Date: Tue, 24 Feb 2004 18:00:29 +0000 To: koffice-devel Subject: Re: [PATCH] Remove code duplication in KoFrame Message-Id: <200402241900.29911.faure () kde ! org> X-MARC-Message: https://marc.info/?l=koffice-devel&m=107764563523357 On Tuesday 24 February 2004 18:06, Matt Rogers wrote: > Hi, > > The attached patch removes some code duplication from KoFrame. It's not a > lot, but it seems safe. :) My younger self seems to agree, since he wrote that comment :) The borders are definitely 0 in Inactive state... But setState isn't called immediately, only when clicking on an embedded object, and the painting will happen before that... Ah, but KoViewChild sets a geometry anyway, I don't know why we need those minimum/maximum sizes at all. Remove the code - in HEAD. -- David Faure, faure@kde.org, sponsored by Trolltech to work on KDE, Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org). _______________________________________________ koffice-devel mailing list koffice-devel@mail.kde.org https://mail.kde.org/mailman/listinfo/koffice-devel