[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    [PATCH] Remove code duplication in KoFrame
From:       Matt Rogers <matt.rogers () kdemail ! net>
Date:       2004-02-24 17:06:01
Message-ID: 200402241106.01602.matt.rogers () kdemail ! net
[Download RAW message or body]

Hi,

The attached patch removes some code duplication from KoFrame.  It's not a 
lot, but it seems safe. :)

Comments?

Matt

["remove_koframe_code_dup1.patch" (text/x-diff)]

Index: koFrame.cc
===================================================================
RCS file: /home/kde/koffice/lib/kofficecore/koFrame.cc,v
retrieving revision 1.20
diff -u -p -b -r1.20 koFrame.cc
--- koFrame.cc	10 Jul 2001 23:14:32 -0000	1.20
+++ koFrame.cc	24 Feb 2004 17:04:49 -0000
@@ -75,20 +75,8 @@ void KoFrame::setView( KoView *view )
 
   d->m_view = view;
   if ( d->m_view )
-  {
     d->m_view->installEventFilter( this );
 
-    // #### Do we need this ?
-    // 1 - it seems border is 0
-    // 2 - setState will be called anyway
-    // (David)
-    setMaximumSize( QMAX32767( d->m_view->maximumWidth() + 2 * border(), d->m_view->maximumWidth() ),
-		    QMAX32767( d->m_view->maximumHeight() + 2 * border(), d->m_view->maximumHeight() ) );
-    setMinimumSize( d->m_view->minimumWidth() + leftBorder() + rightBorder(),
-		    d->m_view->minimumHeight() + topBorder() + bottomBorder() );
-
-  }
-
   resizeEvent( 0L );
 }
 


_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]