[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Please review attached patch
From:       Nicolas Goutte <nicolasg () snafu ! de>
Date:       2004-02-02 0:08:03
Message-ID: 200402020108.03954.nicolasg () snafu ! de
[Download RAW message or body]

On Monday 02 February 2004 00:40, Karl-Heinz Zimmer wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Sonntag, 1. Februar 2004 20:59, Nicolas Goutte wrote:
> (...)
>
> > The problem is DCOP. The DCOP calls are mostly the same as the
> > functions. So if the function is not KURL aware, the DCOP call would
> > be unaware too, which gives later problems for binary compatibility
> > when switching to KURL-aware versions.
> >
> >
> >
> > But here you have perhaps another solution (not tested)
> >
> > bool KPrCanvas::exportPage( int nPage, int nWidth, int nHeight,
> >                             const KURL& url,
> >                             const char* format,
> >                             int quality )
> > {
> >   bool flag=false;
> >   if (url.isLocalFile())
> >     flag=exportPage( nPage, nWidth, nHeight, url.path(), format,
> > quality ); else
> >   {
> >     KTempFile temp;
> >     temp.setAutoDelete(true);
> >     flag=exportPage( nPage, nWidth, nHeight, temp.name(), format,
> > quality ); #if KDE_IS_VERSION(3.1.90)
> >     KIO::NetAccess::upload( this, temp.name(), url );
> > #else
> >     KIO::NetAccess::upload( temp.name(), url );
> > #endif
> >   }
> >   return flag;
> > }
>

> Thanks for the suggestion, I changes my code accordingly - well, nearly
> accordingly only.  It was not so good to use the KURL as DCOP parameter
> but I am using it for the internal function now - that's the one that is
> to be called when the user has entered her width/height values in the
> yet-to-be-developed size dialog.
>
> Combining internal KURL with external QString allowes the dcop user
> to choose whether to specify an url or a normal path.

H'm that is something that I should have thought about earlier. (Now I must 
try to remember which functions I had changed from QString to KURL.)

>
> Please review the attached 5th version of my patch and tell me if it
> is OK to commit it.
>
> Note: There is still a bug - but I am sure it is not in my code - since
>       the positions of the texts and positions of the other objects in
>       the page are correct, but the text-sizes are NOT.
>
> I would prefer to commit my code anyway to get it done, we have to find
> the font size bug independently from this - do you agree?

Good, commit it. We can still look at the detail problems later (for example 
Doxygen comments.)

>
> Karl-Heinz

Have a nice day!

> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)
>
> iD8DBQFAHY53CcaVnbvggDcRAv2dAJ9PgJoF1pHThHwUOq1TGU6/adKWBACghmb5
> sfTwShZdpoUwqSclLwKtbcg=
> =jmXN
> -----END PGP SIGNATURE-----

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]