[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Please review attached patch
From:       Karl-Heinz Zimmer <khz () kde ! org>
Date:       2004-01-31 20:21:24
Message-ID: 200401312121.28951 () postmaster ! bugcops ! org
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Nicolas!

On Samstag, 31. Januar 2004 19:17, Nicolas Goutte wrote:
> On Friday 30 January 2004 02:53, Karl-Heinz Zimmer wrote:
> > Hi,
> >
> > for our hobby project IndeView my son and I desparately need a new
> > function in KPresenter:
> >
> > The ability to store a page in a bitmap format of a give x/y size.
> >
> > This function would be added by the small patch attached, so we
> > are having 3 issues now:
> >
> >
> > 1. Please have a look at the patch and tell me if I may commit.
>
> To avoid always the same problem of not supporting remote files (think
> floppy:), could the filename in the function exportPage be changed
> from QString to KURL?


Please help me understand this!

Does that mean a string like "/media/floppy/myimage.png" would not work
with the current code using QPixmap::save(...) ?

> (I do not mind if the first version is not remote-aware.)

What exactly did you mean by that?

a) Should I replace the QString by a KURL but not support the KURL
   inside the code?  (I would consider this buggy code then)

b) Or could I commit the current version and change it to using
   KURL later?

Karl-Heinz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQFAHA5ICcaVnbvggDcRApM7AKDdrtLEc7uSKdOg5+1p8/LuAVwA+QCcD0Ee
0veG72SXnjK6Dq8ySC+liOU=
=3xf4
-----END PGP SIGNATURE-----

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]