[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] Fix table column resizing
From:       Sven Langkamp <longamp () reallygood ! de>
Date:       2004-01-31 12:46:21
Message-ID: 200401311346.21327.longamp () reallygood ! de
[Download RAW message or body]

Am Thursday 29 January 2004 14:40 schrieb David Faure:
> On Friday 12 December 2003 00:06, Sven Langkamp wrote:
> > Can someone review this and tell me if the solution for #69170 ist ok?
>
> The added layout() in recalCols() is source of much trouble (infinite
> loops) because recalcCols is called by
> KWTextFrameSet::slotAfterFormattingTooMuchSpace, which is part of the text
> layouting code.
It also caused Bug 73351.

> Of course the text layouting can modify the table (by setting a min frame
> height to be big enough so that the text inside a cell is visible), and the
> table layout needs to trigger the text layouting, when resizing a cell, so
> it goes both ways. But calling layout() should only be done when recalcCols
> actually changed something, not unconditionally. I'll revert it for now -
> do you see a way to call it only when something changed? recalcCols()
> surprises me, it doesn't seem to modify any frame...
What about calling it at the end of resizeColumn()?

Sven
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]