[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: kpresenter patch. more code cleanup
From:       Percy Leonhardt <percy () eris23 ! de>
Date:       2004-01-14 14:21:59
Message-ID: 200401141521.59749.percy () eris23 ! de
[Download RAW message or body]

Hi Thorsten,

> next part of cleaning up the source code of kpresenter.

what can I say? Thanks! :-)

Renaming things like 'axisX' and 'axisY' to 'm_rotateCenter' makes the code 
alot more readable. But one thing nevertheless: if you find some 
function-names that are misleading could you please correct them?

For example 'KPrPage::rotateObj' sounds if it rotates one object but you won't 
find one in the parameter list. I find 'KPrPage::rotateSelectedObjects' much 
clearer.

But really, you do a great job for KPresenter! This is only some nitpicking 
from my side...

	Percy :-)

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]