[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    AW: koffice/kspread
From:       Philipp_Müller <philipp.mueller () gmx ! de>
Date:       2004-01-06 9:14:58
Message-ID: DIELKIHKHFIOEGFPLAOHEEENCCAA.philipp.mueller () gmx ! de
[Download RAW message or body]

Hello David,

please revert as it does make sense in the second view.

Reasons:
1. How it behaves now:
It stops now somewhere in the middle of the sheet. Where should it stop? In the last \
filled row? In the last filled cell in your column? What if I'm already below the \
last filled row/cell? What if this cell is not filled but has a lot of cells filled \
left and right of it? Or should it stop at the end of the screen? For me the new \
behaviour and any other similar behaviour is not really predictable and rather \
confusing.

2. If it stops at the sheet ends, then it gives you at least the information: This is \
the end, there are no filled cells left. This information is not available in the new \
way. And you can always easily jump back with 1 single ctrl-up/left.

Trust me, I'm using ctrl-down/right regularly in my daily work and I would miss this \
behaviour. And yes, all other 3 spread sheet apps I tested behave this way as well. \
And finally, we have discussed this long ago. See \
http://lists.kde.org/?l=koffice-devel&m=101696042024044&w=2

Philipp


-----Ursprüngliche Nachricht-----
Von: koffice-devel-bounces-+philipp.mueller=gmx.de@mail.kde.org
[mailto:koffice-devel-bounces-+philipp.mueller=gmx.de@mail.kde.org]Im
Auftrag von David Faure
Gesendet: Donnerstag, 1. Januar 2004 18:55
An: kde-cvs@kde.org
Cc: koffice-devel@kde.org
Betreff: koffice/kspread


CVS commit by faure: 

Fix for CTRL+Right and CTRL+Down: going to row 32767 makes no sense.
Should I backport?
CCMAIL: koffice-devel@kde.org


  M +2 -2      kspread_canvas.cc   1.396


--- koffice/kspread/kspread_canvas.cc  #1.395:1.396
@@ -2134,5 +2134,5 @@ bool KSpreadCanvas::processControlArrowK
 
     if (cell == NULL)
-      row = KS_rowMax;
+      row = marker.y();
     else
       row = cell->row();
@@ -2227,5 +2227,5 @@ bool KSpreadCanvas::processControlArrowK
 
     if (cell == NULL)
-      col = KS_colMax;
+      col = marker.x();
     else
       col = cell->column();


_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]