[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    some patches for kspread and series in general
From:       Marc Heyvaert <marc_heyvaert () yahoo ! com>
Date:       2003-12-27 16:50:53
[Download RAW message or body]

Hello,

Attached to this message you will find 1 file :
patch1.diff

This patch should resolve 2 bugs (reported by me) 
http://bugs.kde.org/show_bug.cgi?id=68952
and
http://bugs.kde.org/show_bug.cgi?id=71230

I already posted a patch to resolve bug 68952 (see
message
http://lists.kde.org/?l=koffice-devel&m=107072771530615&w=2)
but this was never applied because it introduced a new
string, I think...Well if someone would like to take a
look at what I did and apply the patch if it is
suitable.

Working on these series routines, I got quite some
ideas about new features but also about speed-issues.
So I worked on some other code too...(see next
message).

Marc 



__________________________________
Do you Yahoo!?
New Yahoo! Photos - easier uploading and sharing.
http://photos.yahoo.com/
["patch1.diff" (application/octet-stream)]

--- /home/kdevelop/source/kspread_dlg_series_orig.cc	2003-03-23 12:09:20.000000000 \
                +0000
+++ /home/kdevelop/source/kspread_dlg_series.cc	2003-12-14 17:22:13.000000000 +0000
@@ -78,23 +78,14 @@
   params_layout->setAutoAdd( true );
 
   new QLabel( i18n( "Start value:" ), params );
-  start=new KDoubleNumInput(params);
-  start->setMinValue(-9999);
-  start->setMaxValue(9999);
-  start->setValue( 0.0);
+  start=new KDoubleNumInput(-999999.999, 999999.99, 0.0, 1.0, 3, params);
 
   new QLabel( i18n( "Stop value:" ), params );
-  end=new KDoubleNumInput(params);
-  end->setMinValue(-9999);
-  end->setMaxValue(9999);
-  end->setValue( 0.0 );
+  end=new KDoubleNumInput(-999999.999, 999999.99, 0.0, 1.0, 3, params);
 
   new QLabel( i18n( "Step value:" ), params );
-  step=new KDoubleNumInput(params);
-  step->setMinValue(-9999);
-  step->setMaxValue(9999);
-  step->setValue( 0.0 );
-
+  step=new KDoubleNumInput(-999999.999, 999999.99, 0.0, 1.0, 3, params);
+ 
   grid1->addWidget(gb);
 
   grid1->addWidget(gb1);
@@ -109,8 +100,8 @@
 void KSpreadSeriesDlg::slotOk()
 {
 
-  Series mode=Column;
-  Series type=Linear;
+  Series mode=Column;  //same as Vertical
+  Series type=Linear;  // same as Horizontal
   QString tmp;
   double dstep, dend, dstart;
   KSpreadSheet * m_pTable;
@@ -141,6 +132,16 @@
         KMessageBox::error( this, i18n("End value must be greater than the start \
value or the step must be less than '1'!") );  return;
       }
+      if ( dstart == 0 || dend == 0 || dstep == 0)
+      {
+        KMessageBox::error( this, i18n("None of the Start, Stop or Step values may \
be equal to zero!") ); +        return;
+      }
+      if ( dstep == 1)
+      {
+        KMessageBox::error( this, i18n("Step value must be different from 1") );
+        return;
+      }
   }
 
   if (dstep >= 0)



_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]