[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Patch kpresenter. Code cleanup part two
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2003-12-26 9:52:20
[Download RAW message or body]

Hello Percy

On Thursday 25 December 2003 09:55, Percy Leonhardt wrote:
> Hi Thorsten!
>
> > First of all I hope you all have a very nice and joyfull christmas.
>
> Thanks! The same for you!
>
> > I have done some more cleanup in the code. It is still the BrushCmd. I
> > have put all the things that are nessecary for the command into the
> > command. It also fixes a undo problem in brushChosen(). Please review and
> > tell me what you think.
>
> A rather long patch but as far as I can tell it seems to be okay. Only one
> thing I am not sure: In BrushCmd::~BrushCmd() shouldn't there be something
> like
>
> oldBrush.setAutoDelete( true );
> oldBrush.clear();
>
> to get rid of all the old brushes created in addObjects( const
> QPtrList<KPObject> &_objects )?

the code is allready in the destructor.

Thorsten

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]