[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Patch kpresenter. Code cleanup
From:       Percy Leonhardt <percy () eris23 ! de>
Date:       2003-12-22 15:46:13
[Download RAW message or body]

On Monday 22 December 2003 13:38, Thorsten Zachmann wrote:
> this is the first patch for cleaning up the source of kpresenter (HEAD).
> Hopefully more patches to come. Please tell me what you think about it.

Hi Thorsten,

nice patch! Lots of duplicate code removed with an obvious solution. And I 
also prefer your logic (to set in tmpBrush only what has changed) in 
Brush::execute() instead of the former logic (to reset everything in newBrush 
that hasn't changed).

BTW: You (or anyone else) already working on recreating KPresenter dialogs 
with Qt Designer?

	Percy :-)

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]