From koffice-devel Wed Oct 15 08:05:50 2003 From: David Faure Date: Wed, 15 Oct 2003 08:05:50 +0000 To: koffice-devel Subject: Re: Patch for Krita X-MARC-Message: https://marc.info/?l=koffice-devel&m=106620520125328 On Wednesday 15 October 2003 09:41, Boudewijn Rempt wrote: > On Wednesday 15 October 2003 09:27, David Faure wrote: > > > Excellent, very nice to see some activity on krita again. > > Your patch looks fine to me (from a very high perspective). > > > > I only notice some indentation issues due to spaces vs tabs, you'll have > > to define a new indentation model or stick to the existing one (see the new > > "virtual void tabletEvent()" line in kis_canvas.h to see what I mean). > > Oh, I see -- I never noticed there were actual tabs in there -- it's something > I don't expect in source code anymore after having worked for years for > companies that forbade tabs, and after a few years of Python work. > > Would it be acceptable to replace the tabs wholesale with spaces? I'd need to > keep a separate XEmacs mode for Krita otherwise? IMHO yes, 4 spaces everywhere would be very nice, but this is really up to the maintainer. -- David Faure -- faure@kde.org, dfaure@klaralvdalens-datakonsult.se Qt/KDE/KOffice developer Klarälvdalens Datakonsult AB, Platform-independent software solutions _______________________________________________ koffice-devel mailing list koffice-devel@mail.kde.org http://mail.kde.org/mailman/listinfo/koffice-devel