[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Patch for Krita
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2003-10-15 7:41:15
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Wednesday 15 October 2003 09:27, David Faure wrote:

> Excellent, very nice to see some activity on krita again.
> Your patch looks fine to me (from a very high perspective).
>
> I only notice some indentation issues due to spaces vs tabs, you'll have
> to define a new indentation model or stick to the existing one (see the new
> "virtual void tabletEvent()" line in kis_canvas.h to see what I mean).

Oh, I see -- I never noticed there were actual tabs in there -- it's something  
I don't expect in source code anymore after having worked for years for 
companies that forbade tabs, and after a few years of Python work. 

Would it be acceptable to replace the tabs wholesale with spaces? I'd need to 
keep a separate XEmacs mode for Krita otherwise?

-- 
Boudewijn Rempt | http://www.valdyas.org/index2.html

[Attachment #5 (application/pgp-signature)]

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]