[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] Fix for kpresenter bug #63032
From:       Peter Simonsson <psn () linux ! se>
Date:       2003-10-09 16:07:16
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 09 October 2003 15:40, Thorsten Zachmann wrote:
> On Thursday 09 October 2003 15:13, Lukáš Tinkl wrote:
> > Dne čt 9. října 2003 13:42 Peter Simonsson napsal(a):
> > > On Thursday 09 October 2003 06:13, Thorsten Zachmann wrote:
> > > > Hello Peter and all,
> > > >
> > > > > > I do not know how to fix this.
> > > > > >
> > > > > > I think there are two possibilities to solve this problem as the
> > > > > > new behavior is not realy much better than the old one.
> > > > > >
> > > > > > 1. fix remaining problems (no idea at the moment how it could be
> > > > > > done) 2. revert the patch
> > > > > >
> > > > > > What do you thing should be done.
> > > > >
> > > > > Ok here's a new patch that should (hopefully ;)) fix your last
> > > > > problems... (it contains your patch too)
> > > > >
> > > > > Ok, to commit? ( and please test before answering ;))
> > > >
> > > > As I came home yesterday I also looked for a solution and found one
> > > > (patch is attached). So now we have two patches.
> > > >
> > > > My patch moves the deciding of the "Snap to Grid" into the moveObject
> > > > function, in calculating the dx,dy so that it will snap to the grid.
> > > > I thing that way it is easy to understand what is done. What do you
> > > > think?
> > > >
> > > > I haven't tested your patch yet so I can't say if it works now. But I
> > > > will do so today. Can you also please test my patch, than we can
> > > > decide which patch is better and apply that one.
> > > >
> > > > Lets test.
> > >
> > > The difference between the patches is that mine treats the page edge as
> > > part of the grid... Don't know if that is desirable or not (I think
> > > so), Lukas?
> >
> > Yes, I think so too
>
> Also my patch treats the page edge as part of the grid.
>
Not if the page edge isn't on the grid (on the right side and at the 
bottom)....

> I tested both patches and noticed that the grid with my patch and the patch
> of Peter is different. So I decided to look into the generated xml-code to
> see which really aligns to the grid.
>
> I created an object and resized it to the first grid ( top of object ) and
> to the second grid ( bottom of object ). Now the size of the object and the
> y pos of the object should be the same
>
> Here are the relevant parts of maindoc.xml
>
> with Peter's patch:
>   <OBJECT type="2" >
>    <ORIG x="20" y="27.2" />
>    <SIZE width="10" height="29.7333" />
>
> with my patch:
>
>   <OBJECT type="2" >
>    <ORIG x="20" y="28.3465" />
>    <SIZE width="10" height="28.3465" />
>
> Also I noticed with the patch from you (Peter) resizing up and down don't
> come to the same position. There is a small difference in the pos.
>
> Is it ok to commit my patch? What do you think?
> If you think it is ok I will refactor the applyGrid a little bit so that it
> works for both axis seperatly.
>
It's ok with me...
- -- 
LLaP
Peter Simonsson

Kivio (KOffice Flowcharting Application) - http://www.koffice.org/kivio/
Kexi - http://www.koffice.org/kexi/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE/hYe5jR6JKcrOq3sRAhc8AJ9jjGG+NcAXfJKz2rDjkjenXYm0wgCgrXwi
QdpCP/ttqWDU5H8UE0Hfb2o=
=Y1uu
-----END PGP SIGNATURE-----
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]