[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] Fix for kpresenter bug #63032
From:       Peter Simonsson <psn () linux ! se>
Date:       2003-10-09 11:42:38
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 09 October 2003 06:13, Thorsten Zachmann wrote:
> Hello Peter and all,
>
> > > I do not know how to fix this.
> > >
> > > I think there are two possibilities to solve this problem as the new
> > > behavior is not realy much better than the old one.
> > >
> > > 1. fix remaining problems (no idea at the moment how it could be done)
> > > 2. revert the patch
> > >
> > > What do you thing should be done.
> >
> > Ok here's a new patch that should (hopefully ;)) fix your last
> > problems... (it contains your patch too)
> >
> > Ok, to commit? ( and please test before answering ;))
>
> As I came home yesterday I also looked for a solution and found one (patch
> is attached). So now we have two patches.
>
> My patch moves the deciding of the "Snap to Grid" into the moveObject
> function, in calculating the dx,dy so that it will snap to the grid. I
> thing that way it is easy to understand what is done. What do you think?
>
> I haven't tested your patch yet so I can't say if it works now. But I will
> do so today. Can you also please test my patch, than we can decide which
> patch is better and apply that one.
>
> Lets test.
The difference between the patches is that mine treats the page edge as part 
of the grid... Don't know if that is desirable or not (I think so), Lukas?

- -- 
LLaP
Peter Simonsson

Kivio (KOffice Flowcharting Application) - http://www.koffice.org/kivio/
Kexi - http://www.koffice.org/kexi/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE/hUmzjR6JKcrOq3sRAqvxAJ9y2D6XHlL6d8XQOz9BsRN98oKUPgCfUb/A
q69Z7wW8foE62ApIuBXvKBA=
=j2Ga
-----END PGP SIGNATURE-----
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]