[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] Time stuff for date variable
From:       Thomas Zander <zander () microweb ! nl>
Date:       2003-09-19 7:34:17
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 18 September 2003 00:27, Nicolas Goutte wrote:
> The attached patch is for koffice/lib/kotext.
>
> As the date variable can do time display too, this patch adds:
> - add the time codings in the custom combo box
> - add a few date/time choices in the default combo box

About this part:

diff -u -r1.126 kovariable.cc
- --- kovariable.cc	29 Aug 2003 13:13:33 -0000	1.126
+++ kovariable.cc	17 Sep 2003 22:14:52 -0000
@@ -221,6 +221,10 @@
     listDateFormat<<"yyyy-MM-dd";
     listDateFormat<<"dd/yy";
     listDateFormat<<"MMMM";
+    listDateFormat<<"yyyy-MM-dd hh:mm:ss";
+    listDateFormat<<"yyyy-MM-ddThh:mm:ss"; // ISO 8601
+    listDateFormat<<"dd.MMM.yyyy hh:mm";
+    listDateFormat<<"MMM dd,yyyy h:mm AP";

I read that (please correct me if I am wrong) as addition to the combobox, 
so the above time formats can be chosen as well.
If so, then I don't think you want that. Time/data formats are locale aware 
and adding DDMMYY type of dates are useless for the american crowds.
This is why the 'locale' entry is there.

Since there are already quite some lines in there (and they are not 
particularly readable, maybe examples would be better) adding more is 
something I don't think will enhance usability.

- -- 
Thomas Zander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE/arF8CojCW6H2z/QRAtCeAKCWcR22bvt59ok8tzHxJU++YtOPcwCgyZgX
y4lqbX2JpshQJY6q506tAj0=
=Z1Er
-----END PGP SIGNATURE-----
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]