[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    kpresenter patch
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2003-08-31 10:22:22
[Download RAW message or body]

Hello all 

I found some problems with flipping pie objects. ( no flipping when angle = 
180° || 270° || 360°, after 2 time horizontal flipping of a pie with angle 
45° and length 170° no more flipping possible). 

The attached patch solves the problems and simpifies the code.

Is it ok to commit?

Thorsten

["patch48" (text/x-diff)]

Index: kppieobject.cc
===================================================================
RCS file: /home/kde/koffice/kpresenter/kppieobject.cc,v
retrieving revision 1.42
diff -u -3 -p -r1.42 kppieobject.cc
--- kppieobject.cc	27 Aug 2003 14:45:39 -0000	1.42
+++ kppieobject.cc	31 Aug 2003 10:16:08 -0000
@@ -167,24 +167,15 @@ void KPPieObject::flip( bool horizontal 
     KP2DObject::flip( horizontal );
     if ( horizontal )
     {
-        if ( p_angle <= 90*16 )
-            p_angle = (360*16 - p_angle -p_len);
-        else if ( p_angle >90*16 && p_angle <180*16 )
-            p_angle = (p_angle + 90*16 + p_len) ;
-        else if ( p_angle >180*16 && p_angle <270*16 )
-            p_angle = (360*16 - (p_angle + p_len))%(360*16);
-        else if ( p_angle >270*16 && p_angle <360*16 )
-            p_angle = (360*16-p_angle -p_len)%(360*16);
+        p_angle = 360*16 - p_angle -p_len;
     }
     else
     {
-        if ( p_angle <= 90*16 )
-            p_angle = 180*16- p_angle - p_len;
-        else if ( p_angle >90*16 && p_angle <180*16 )
-            p_angle = 180*16 - p_angle - p_len  ;
-        else if ( p_angle >180*16 && p_angle <270*16 )
-            p_angle = 360*16 - (p_angle - 180*16) - p_len;
-        else if ( p_angle >270*16 && p_angle <360*16 )
-            p_angle = 180*16+ (360*16 - (p_angle+p_len));
+        p_angle = 180*16 - p_angle - p_len;
+    }
+    
+    // angle smaller 0°
+    while ( p_angle < 0 ) {
+        p_angle += 360*16;
     }
 }


_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]