From koffice-devel Wed Aug 27 22:29:47 2003 From: Nicolas Goutte Date: Wed, 27 Aug 2003 22:29:47 +0000 To: koffice-devel Subject: Re: [PATCH] OOWriter: OASIS is not version 1 X-MARC-Message: https://marc.info/?l=koffice-devel&m=106202462609670 I will check that. But for now, it seems that align="auto" does not go to the filter. I have no idea if it was my test or if it is a real problem. As for omitting the version, I do not know if it does not give any problem. That is a reason why I did not commit. Section 1.8.1 of the OO file format documentation tells that it is possible (or even necessary.) So I will continue to check this tomorrow (well, it's already today.) I just had that problem on my to-do list. That is why I made the patch. But I think it is not mature yet. As for why making it optionally, I think that the document should have a version number if it can. (Buggy readers will surely exist if the file format become more popular.) Have a nice day! On Wednesday 27 August 2003 23:50, David Faure wrote: > On Wednesday 27 August 2003 23:13, Nicolas Goutte wrote: > > The attached patch is for koffice/filter/kword/oowriter > > > > It only writes that the OO document is version 1.0 if there is no (oASIS) > > extension. > > > > The reason behind the patch is that section 1.8.1 of the OO file format > > specifiaction allow the XML document to be read by a validating parser if > > there is a version number known by the reading program. Avoid writing a > > version number means that it is not allowed to use a validating parser. > > Hmm, didn't think about that. > This won't do much though, since styles default to align=auto, it basically > means that the version 1 thing will never be written out. > > OOo is supposed to ignore attributes it doesn't know about, so we're not > really doing anything wrong here, by using our own attribute... > > Do you mean that office-version is really the OOo version, and that it > doesn't create any problem to omit it? In that case we might as well > omit it completely, it feels a bit strange to optionally set it. _______________________________________________ koffice-devel mailing list koffice-devel@mail.kde.org http://mail.kde.org/mailman/listinfo/koffice-devel