From koffice-devel  Thu Aug 07 09:50:11 2003
From: Clarence Dang <dang () kde ! org>
Date: Thu, 07 Aug 2003 09:50:11 +0000
To: koffice-devel
Subject: Patches for review
X-MARC-Message: https://marc.info/?l=koffice-devel&m=106024997728656
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--Boundary_(ID_VO+OFrq6r7humPjFDgv8kw)"


--Boundary_(ID_VO+OFrq6r7humPjFDgv8kw)
Content-type: text/plain; charset=iso-8859-2
Content-transfer-encoding: 8BIT


Hi,

On Wed, 6 Aug 2003 08:19 pm, Lukáš Tinkl wrote:
> KOffice is effectively in feature freeze now which means no commits unless
> reviewed here on this list.

Speaking of which:  :)

1. The attached patch ensures that the correct mouse cursor is used when 
KoFilterManager pops up KoFilterChooser.  Is this ok to commit?

2. Could someone please review the fix I posted to bug #61571 so that it can 
be closed?

Thanks,
Clarence



--Boundary_(ID_VO+OFrq6r7humPjFDgv8kw)
Content-type: text/x-diff; charset=iso-8859-2; name=cursor.patch
Content-transfer-encoding: 7BIT
Content-disposition: attachment; filename=cursor.patch

Index: koFilterManager.cc
===================================================================
RCS file: /home/kde/koffice/lib/kofficecore/koFilterManager.cc,v
retrieving revision 1.128
diff -u -p -r1.128 koFilterManager.cc
--- koFilterManager.cc	9 Jun 2003 12:04:28 -0000	1.128
+++ koFilterManager.cc	7 Aug 2003 09:42:18 -0000
@@ -146,6 +146,8 @@ QString KoFilterManager::import( const Q
         if ( m_document )
         {
             QCString nativeFormat = m_document->nativeFormatMimeType ();
+
+            QApplication::setOverrideCursor (arrowCursor);
             KoFilterChooser *chooser = new KoFilterChooser
                                             (0,
                                             KoFilterManager::mimeFilter (nativeFormat, KoFilterManager::Import),
@@ -166,6 +168,7 @@ QString KoFilterManager::import( const Q
                 userCancelled = true;
 
             delete chooser;
+            QApplication::restoreOverrideCursor ();
         }
 
         if (!m_graph.isValid())
@@ -239,6 +242,7 @@ KoFilter::ConversionStatus KoFilterManag
         if ( !m_graph.isValid() ) {
             kdWarning(s_area) << "Can't open " << t->name () << ", trying filter chooser" << endl;
 
+            QApplication::setOverrideCursor (arrowCursor);
             KoFilterChooser *chooser = new KoFilterChooser (0, KoFilterManager::mimeFilter ());
             if (chooser->exec ())
                 m_graph.setSourceMimeType (chooser->filterSelected ().latin1 ());
@@ -246,6 +250,7 @@ KoFilter::ConversionStatus KoFilterManag
                 userCancelled = true;
 
             delete chooser;
+            QApplication::restoreOverrideCursor ();
         }
     }
 

--Boundary_(ID_VO+OFrq6r7humPjFDgv8kw)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel

--Boundary_(ID_VO+OFrq6r7humPjFDgv8kw)--